Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry incomplete address book during acceptance tests #9744

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

steven-sheehy
Copy link
Member

Description:

Retry incomplete address book during acceptance tests

Related issue(s):

Fixes #9743

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@steven-sheehy steven-sheehy added enhancement Type: New feature test Test infrastructure, automated tests required, etc labels Nov 12, 2024
@steven-sheehy steven-sheehy added this to the 0.118.0 milestone Nov 12, 2024
@steven-sheehy steven-sheehy self-assigned this Nov 12, 2024
@steven-sheehy steven-sheehy requested a review from a team as a code owner November 12, 2024 04:39
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (15f8244) to head (2c6d598).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9744   +/-   ##
=========================================
  Coverage     92.23%   92.23%           
  Complexity     7628     7628           
=========================================
  Files           937      937           
  Lines         32119    32119           
  Branches       4071     4071           
=========================================
+ Hits          29624    29625    +1     
  Misses         1542     1542           
+ Partials        953      952    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 12, 2024

Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@jnels124 jnels124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 35367e5 into main Nov 12, 2024
34 checks passed
@steven-sheehy steven-sheehy deleted the 9743-retry-address-book branch November 12, 2024 15:39
@steven-sheehy steven-sheehy modified the milestones: 0.118.0, 0.119.0 Nov 12, 2024
steven-sheehy added a commit that referenced this pull request Nov 12, 2024
steven-sheehy added a commit that referenced this pull request Nov 12, 2024
steven-sheehy added a commit that referenced this pull request Nov 12, 2024
Retry incomplete address book during acceptance tests (#9744)

Signed-off-by: Steven Sheehy <[email protected]>
steven-sheehy added a commit that referenced this pull request Nov 12, 2024
Retry incomplete address book during acceptance tests (#9744)

Signed-off-by: Steven Sheehy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature test Test infrastructure, automated tests required, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retry acceptance tests when incomplete address book
4 participants